Do we assume that all grouped effects have the mutex, and we draw a "or" between all effects? Or is it possible that two effects have the mutex, and another effect in the same group always applies? (this seems too complex to me, we would need to review existing cards to know whether or not this exists.)
Do we assume that all effects with a mutex can be drawn in a sphere? Or can a "4 dmg OR draw 1 card" combination can exist?
Surprisingly not trivial.
Honestly, I would argue that the "or" solution in-between effects is not optimal. We could instead draw a background filled with question marks, or something like that, to solve a few of the above issues.
For the "some effects aren't in the mutex while others are" part, we could just put those in different group of effects I guess!
What do y'all think?
The below part of the code seems p interesting to solve this issue.
https://git.legonzaur.fr/heronfief/cards-gen/src/commit/f766c559d695315b460bc0af275364623938cc82/src/draw_functions.py#L343
There are many associated questions:
- Do we assume that all grouped effects have the mutex, and we draw a "or" between all effects? Or is it possible that two effects have the mutex, and another effect in the same group always applies? (this seems too complex to me, we would need to review existing cards to know whether or not this exists.)
- Do we assume that all effects with a mutex can be drawn in a sphere? Or can a "4 dmg OR draw 1 card" combination can exist?
Surprisingly not trivial.
Honestly, I would argue that the "or" solution in-between effects is not optimal. We could instead draw a background filled with question marks, or something like that, to solve a few of the above issues.
For the "some effects aren't in the mutex while others are" part, we could just put those in different group of effects I guess!
What do y'all think?
Ended up restoring a simple "ou" text between the effects. we might want the spacing to be bigger between effects when this occurs
A problem still exists for:
Cat Familiar (missing "ou", not far from the solution but got carjacked by family)
Trash (missing vertical "ou" for mutex between effect with circle and text)
Ended up restoring a simple "ou" text between the effects. we might want the spacing to be bigger between effects when this occurs
A problem still exists for:
- Cat Familiar (missing "ou", not far from the solution but got carjacked by family)
- Trash (missing vertical "ou" for mutex between effect with circle and text)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The OR condition is not clear, despite being effective on click
The below part of the code seems p interesting to solve this issue.
There are many associated questions:
Surprisingly not trivial.
Honestly, I would argue that the "or" solution in-between effects is not optimal. We could instead draw a background filled with question marks, or something like that, to solve a few of the above issues.
For the "some effects aren't in the mutex while others are" part, we could just put those in different group of effects I guess!
What do y'all think?
Ended up restoring a simple "ou" text between the effects. we might want the spacing to be bigger between effects when this occurs
A problem still exists for:
and woop, fixed both problems in a relatively elegant way, theres some margin for constructive criticism but this shall do