heronfief/front
3
1
Fork 0
Code Issues 44 Pull Requests 1 Actions Packages Projects Releases 1 Activity

[Game] Button to return to lobby #75

New Issue
Open
opened 2024-05-18 17:51:16 +00:00 by Erzangel · 4 comments
Erzangel commented 2024-05-18 17:51:16 +00:00
Owner
Copy Link
Copy Source

I would link this to routing personally, a game should not be in the same route

I would link this to routing personally, a game should not be in the same route
Fhuris added this to the 1.1 milestone 2024-05-18 17:57:51 +00:00
legonzaur added the enhancement label 2024-05-19 20:43:52 +00:00
legonzaur added this to the HeronSkyMap project 2024-05-19 20:49:14 +00:00
legonzaur added a new dependency 2024-05-19 20:54:12 +00:00
#84 [Game] Show champions on a different row than other cards
legonzaur removed a dependency 2024-05-19 20:54:17 +00:00
#84 [Game] Show champions on a different row than other cards
legonzaur commented 2024-05-19 20:55:24 +00:00
Owner
Copy Link
Copy Source

Cleaner way would be to add #26 as a dependency but we might want to implement a a workaround without routes before 2.0

Cleaner way would be to add #26 as a dependency but we might want to implement a a workaround without routes before 2.0
Erzangel commented 2024-05-22 17:54:32 +00:00
Author
Owner
Copy Link
Copy Source

@legonzaur, how dirty would it be in the frontend code to do something like "goStore.context = lobby"? I see that all "page transitions" are done with a call to the websocket, but when we leave a game I suppose we do not need such a thing

@legonzaur, how dirty would it be in the frontend code to do something like "goStore.context = lobby"? I see that all "page transitions" are done with a call to the websocket, but when we leave a game I suppose we do not need such a thing
Erzangel added the question label 2024-05-22 17:54:36 +00:00
legonzaur commented 2024-05-25 07:48:48 +00:00
Owner
Copy Link
Copy Source

@legonzaur, how dirty would it be in the frontend code to do something like "goStore.context = lobby"? I see that all "page transitions" are done with a call to the websocket, but when we leave a game I suppose we do not need such a thing

With how the websocket currently works, it is not possible at all. Context is sent by the backend and represents a set of available calls that the backend can currently accept from the client. It is not possible to change this on the client side.

A cleaner solution would be to wait for 2.0. As I will implement multiplexing, the context property shouldn't be used anymore.

> @legonzaur, how dirty would it be in the frontend code to do something like "goStore.context = lobby"? I see that all "page transitions" are done with a call to the websocket, but when we leave a game I suppose we do not need such a thing With how the websocket currently works, it is not possible at all. Context is sent by the backend and represents a set of available calls that the backend can currently accept from the client. It is not possible to change this on the client side. A cleaner solution would be to wait for 2.0. As I will implement multiplexing, the context property shouldn't be used anymore.
legonzaur commented 2024-05-25 07:49:37 +00:00
Owner
Copy Link
Copy Source

A workaround before 2.0 to return to the lobby would be to reload the page.

A workaround before 2.0 to return to the lobby would be to reload the page.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
complexity
easy
complexity
hard
complexity
medium
complexity
trivial
duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels enhancement question
Milestone
No items
No Milestone 1.1
Projects
Clear projects
No projects
HeronSkyMap
Uncategorized
Assignees
Clear assignees
Erzangel Fhuris legonzaur
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: heronfief/front#75